Types revamp #423
Merged
Types revamp #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeScript definitions are now bundled into each notifier so that no extra modules need to be installed to get the relevant .d.ts files. In short this means types should "just work".
bengourley
commented
Nov 20, 2018
| @@ -30,14 +30,11 @@ | |||
| "node", | |||
| "types.d.ts" | |||
| ], | |||
| "scripts": { | |||
| "postversion": "npm run build" | |||
There was a problem hiding this comment.
this was on the wrong package, it should have been on node.
bengourley
commented
Nov 20, 2018
| "build:dist": "../../bin/bundle src/notifier.js --node --exclude=iserror,stack-generator,error-stack-parser,request,pump,byline --standalone=bugsnag | ../../bin/extract-source-map dist/bugsnag.js", | ||
| "test": "bundle exec maze-runner" | ||
| "test": "bundle exec maze-runner", | ||
| "postversion": "npm run build" |
There was a problem hiding this comment.
The node assets were not built when each version was created. This was the cause.
bengourley
force-pushed
the
u/types-revamp
branch
from
4486208
to
de7e4cc
Compare
kattrali
approved these changes
Nov 21, 2018
fix(node): Disable breadcrumbs on Node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR mean that TypeScript users only have to install
@bugsnag/js– nothing extra – to get the JS and the types.This is achieved by a script which copies the
@bugsnag/coretypes into each of@bugsnag/browserand@bugsnag/node, with an update to the import paths for the.d.tsfiles in those modules. This happens at build time.This PR also fixes the type def for the
client.use()method.